stwaidele/dorfteich
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 22 Wiki Activity

Unambiguous delete row/column toolbar icons (#336) #341

Merged
fable-5 merged 1 commits from issue-336-delete-icons into main 2026-08-16 05:21:18 +02:00
Conversation 0 Commits 1 Files Changed 1 +5 -2
fable-5 commented 2026-08-15 18:44:53 +02:00
Collaborator
Copy Link

The table toolbar's delete buttons paired a minus-box with a double arrow, which reads as 'resize/expand' rather than 'delete'. They now use axis stripes plus the x delete marker that deleteTable already established (screenshot attached to #336). Labels/tooltips were correct all along and stay unchanged.

Stacked on #340 (fast-forward chain).

Closes #336

The table toolbar's delete buttons paired a minus-box with a double arrow, which reads as 'resize/expand' rather than 'delete'. They now use axis stripes plus the x delete marker that deleteTable already established (screenshot attached to #336). Labels/tooltips were correct all along and stay unchanged. Stacked on #340 (fast-forward chain). Closes #336
fable-5 added 2 commits 2026-08-15 18:44:53 +02:00
Gap cursor for block-edge positions (#335)
Some checks failed
CI / Lint, typecheck, test (pull_request) Successful in 6m52s
Details
CI / Build container images (pull_request) Successful in 1m13s
Details
CI / Auth e2e pack (pull_request) Successful in 9m25s
Details
CI / Import/export fidelity gate (pull_request) Successful in 58s
Details
CD / Deploy to Test (push) Blocked by required conditions
Details
CD / Smoke tests against Test (push) Blocked by required conditions
Details
CD / Promote to Int (push) Blocked by required conditions
Details
CI / Auth e2e pack (push) Blocked by required conditions
Details
CI / Import/export fidelity gate (push) Blocked by required conditions
Details
CI / Build container images (push) Blocked by required conditions
Details
CI / Lint, typecheck, test (push) Has been cancelled
Details
CD / Build and push images (push) Has been cancelled
Details
69563348ca 
A table (or any other block node without a text position of its own) as
the page's first, last, or only block was unreachable from before/after:
neither mouse nor arrow keys could place the cursor there, so no
paragraph could be created around it.

- add the prosemirror-gapcursor plugin as a TipTap extension (via
  @tiptap/pm, no new dependency; schema-neutral, so the editorSchema
  drift fence is unaffected)
- style the gap cursor bar in base.css -- the upstream package does not
  ship its stylesheet through our import path; the blink animation
  honors prefers-reduced-motion
- e2e: keyboard-only round trip that creates paragraphs before and
  after a lone table

Closes #335

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012aoPvnakfBP28nAfijgUY9
Unambiguous delete row/column toolbar icons (#336)
Some checks failed
CI / Lint, typecheck, test (pull_request) Successful in 6m52s
Details
CI / Build container images (pull_request) Successful in 1m12s
Details
CI / Auth e2e pack (pull_request) Successful in 9m24s
Details
CI / Import/export fidelity gate (pull_request) Successful in 58s
Details
CD / Deploy to Test (push) Blocked by required conditions
Details
CD / Smoke tests against Test (push) Blocked by required conditions
Details
CD / Promote to Int (push) Blocked by required conditions
Details
CI / Auth e2e pack (push) Blocked by required conditions
Details
CI / Import/export fidelity gate (push) Blocked by required conditions
Details
CI / Build container images (push) Blocked by required conditions
Details
CD / Build and push images (push) Has been cancelled
Details
CI / Lint, typecheck, test (push) Has been cancelled
Details
b1165a37e6 
The delete buttons paired the minus-box with a double arrow (bidirectional
arrows next to the symbol) which reads as "resize/expand", not "delete".
Replace them with axis stripes plus the x delete marker that deleteTable
already established: vertical stripes with x for delete column, horizontal
stripes with x for delete row. Labels/tooltips were correct all along and
stay unchanged.

Closes #336

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012aoPvnakfBP28nAfijgUY9
fable-5 merged commit b1165a37e6 into main 2026-08-16 05:21:18 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area:auth

   
area:docs

   
area:export

   
area:ops

   
area:storage

   
area:supply-chain

   
auth

Authentication, permissions, quotas

  
backend

API server (apps/api)

  
blocked

Blocked on external dependency/infrastructure

  
collab

Collaboration server (apps/collab)

  
deployment

Docker, CI/CD, hosting

  
docs

Documentation

  
effort:L

   
effort:M

   
effort:S

   
frontend

SPA (apps/web)

  
plugins

Plugin system and SDK

  
qa

Tests, fixtures, e2e

  
vs-nfd

   
vs-nfd:blocker
No Label
area:auth
area:docs
area:export
area:ops
area:storage
area:supply-chain
auth
backend
blocked
collab
deployment
docs
effort:L
effort:M
effort:S
frontend
plugins
qa
vs-nfd
vs-nfd:blocker
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stwaidele/dorfteich#341
No description provided.
Delete Branch "issue-336-delete-icons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?