stwaidele/dorfteich
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 22 Wiki Activity

Fix admin general settings form: dot-free field names, flat PATCH keys (#322) #326

Merged
fable-5 merged 2 commits from 322-admin-settings-form-flat-keys into main 2026-08-04 12:43:53 +02:00
Conversation 0 Commits 2 Files Changed 6 +215 -26
fable-5 commented 2026-08-04 11:18:44 +02:00
Collaborator
Copy Link

Closes #322.

The general + quota cards registered react-hook-form fields under the DOTTED settings keys; RHF nests on input, the strict PATCH schema rejects the body, and the form looks fine while never saving -- on every instance. Found by Stefan on a fresh self-hosted install (dt.leisinger.info), confirmed on dorfteich.online.

  • New admin-settings-form.ts: dot-free form model, one explicit field->setting mapping, converters both ways; submit carries only the settings these cards edit.
  • Saving now also invalidates the branding query (TopBar shows the new instance name immediately).
  • New e2e pack admin-settings.spec.ts (registered in ci.yml with its own rate-limit reset): renames THROUGH the form, asserts success message, TopBar update, reload persistence, api value. Locally verified to FAIL against the unfixed page and pass against the fix.
  • Unit test pins: no form field name contains a dot; mapping round-trips.

Local evidence: new pack green against the dev stack; negative check red against origin/main's page; web unit suite 141 green; typecheck + lint green; api full suite against fresh DB 597 green (one documented ECONNRESET load flake, green isolated).

🤖 Generated with Claude Code

https://claude.ai/code/session_017aviRTgWCcAHUh1SBoxf6P

Closes #322. The general + quota cards registered react-hook-form fields under the DOTTED settings keys; RHF nests on input, the strict PATCH schema rejects the body, and the form looks fine while never saving -- on every instance. Found by Stefan on a fresh self-hosted install (dt.leisinger.info), confirmed on dorfteich.online. - New admin-settings-form.ts: dot-free form model, one explicit field->setting mapping, converters both ways; submit carries only the settings these cards edit. - Saving now also invalidates the branding query (TopBar shows the new instance name immediately). - New e2e pack admin-settings.spec.ts (registered in ci.yml with its own rate-limit reset): renames THROUGH the form, asserts success message, TopBar update, reload persistence, api value. Locally verified to FAIL against the unfixed page and pass against the fix. - Unit test pins: no form field name contains a dot; mapping round-trips. Local evidence: new pack green against the dev stack; negative check red against origin/main's page; web unit suite 141 green; typecheck + lint green; api full suite against fresh DB 597 green (one documented ECONNRESET load flake, green isolated). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_017aviRTgWCcAHUh1SBoxf6P
fable-5 added 1 commit 2026-08-04 11:18:44 +02:00
Fix admin general settings form: dot-free field names, flat PATCH keys (#322)
Some checks failed
CI / Lint, typecheck, test (pull_request) Successful in 6m42s
Details
CI / Build container images (pull_request) Successful in 1m20s
Details
CI / Auth e2e pack (pull_request) Failing after 10m3s
Details
CI / Import/export fidelity gate (pull_request) Has been skipped
Details
9f754649d4 
The general and quota cards registered their react-hook-form fields under
the dotted settings keys. RHF treats dots as nested-path separators, so
the form DISPLAYED fine (its getter falls back to the literal flat key)
but typing nested the value ({ instance: { name } }) and the api's strict
PATCH schema rejected the body — none of these fields ever saved through
the UI, on any instance. Found by Stefan on a fresh self-hosted install.

- admin-settings-form.ts: dot-free form model with one explicit mapping
  to the dotted settings keys and converters in both directions; the
  submit now also carries ONLY the settings these cards edit, so the
  internal branding metadata keys never ride along.
- Saving invalidates the branding query too — the TopBar reads the
  instance name from it and kept the old name until its staleTime ran out.
- admin-settings.spec.ts (new e2e pack, registered in ci.yml): drives the
  rename THROUGH THE FORM — success message, TopBar update without
  reload, value survives reload, api returns it. Verified locally to fail
  against the unfixed page and pass against the fix. Every existing
  admin-settings test patched the api directly, which is why this bug was
  invisible to CI.
- admin-settings-form.test.ts pins that no form field name contains a dot
  and the mapping round-trips.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017aviRTgWCcAHUh1SBoxf6P
fable-5 added 1 commit 2026-08-04 11:42:57 +02:00
Follow the field rename in vs-nfd-marking locators
Some checks failed
CI / Lint, typecheck, test (pull_request) Successful in 7m0s
Details
CI / Build container images (pull_request) Successful in 1m23s
Details
CI / Auth e2e pack (pull_request) Successful in 9m0s
Details
CI / Import/export fidelity gate (pull_request) Successful in 1m1s
Details
CD / Deploy to Test (push) Blocked by required conditions
Details
CD / Smoke tests against Test (push) Blocked by required conditions
Details
CD / Promote to Int (push) Blocked by required conditions
Details
CI / Auth e2e pack (push) Blocked by required conditions
Details
CI / Import/export fidelity gate (push) Blocked by required conditions
Details
CI / Build container images (push) Blocked by required conditions
Details
CI / Lint, typecheck, test (push) Has been cancelled
Details
CD / Build and push images (push) Has been cancelled
Details
4d6a27194f 
The pack addresses the registration-mode select by its DOM name
attribute, which react-hook-form derives from the field name — now
`registrationMode` (dot-free, see admin-settings-form.ts). Caught by CI
run 713; the pack needs VS_NFD_MODE stages and was not part of the local
verification set.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017aviRTgWCcAHUh1SBoxf6P
fable-5 merged commit 4d6a27194f into main 2026-08-04 12:43:53 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area:auth

   
area:docs

   
area:export

   
area:ops

   
area:storage

   
area:supply-chain

   
auth

Authentication, permissions, quotas

  
backend

API server (apps/api)

  
blocked

Blocked on external dependency/infrastructure

  
collab

Collaboration server (apps/collab)

  
deployment

Docker, CI/CD, hosting

  
docs

Documentation

  
effort:L

   
effort:M

   
effort:S

   
frontend

SPA (apps/web)

  
plugins

Plugin system and SDK

  
qa

Tests, fixtures, e2e

  
vs-nfd

   
vs-nfd:blocker
No Label
area:auth
area:docs
area:export
area:ops
area:storage
area:supply-chain
auth
backend
blocked
collab
deployment
docs
effort:L
effort:M
effort:S
frontend
plugins
qa
vs-nfd
vs-nfd:blocker
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stwaidele/dorfteich#326
No description provided.
Delete Branch "322-admin-settings-form-flat-keys"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?