CI workflow: lint, typecheck, unit tests, build on every PR #7

New Issue

fable-5 · 2026-07-04T14:51:58+02:00

fable-5 commented

2026-07-04 14:51:58 +02:00

Context

ADR 0014: PRs must be objectively green before merge; this is the first pipeline stage.

Scope

Create the Gitea Actions workflow .gitea/workflows/ci.yml running on pull_request and push to main: pnpm install (cached), lint, typecheck, test, i18n:check, build, and Docker image builds (no push on PRs). Configure the repo (documented for the repo owner) to require the workflow for merging.

Acceptance criteria

a PR with a failing unit test shows a red check and cannot be merged
a green PR shows all steps passing in under ~10 minutes (use caching)
workflow file is commented so contributors understand each job

Technical notes

ADR 0014. Runner: act_runner on LEISINGER with Docker — coordinate its availability with the repo owner (a note in the issue is enough; the runner installation itself is #9).

Dependencies

Depends on #1, #5, #6.

Size: ~1 day

Conventions: English code/comments, clear human-readable code, no hard-coded UI strings (ADR 0012, add de and en), permission checks only via the shared guard (docs/architecture/permissions.md). Read the referenced ADRs before starting.

## Context ADR 0014: PRs must be objectively green before merge; this is the first pipeline stage. ## Scope Create the Gitea Actions workflow `.gitea/workflows/ci.yml` running on pull_request and push to main: pnpm install (cached), `lint`, `typecheck`, `test`, `i18n:check`, `build`, and Docker image builds (no push on PRs). Configure the repo (documented for the repo owner) to require the workflow for merging. ## Acceptance criteria - [ ] a PR with a failing unit test shows a red check and cannot be merged - [ ] a green PR shows all steps passing in under ~10 minutes (use caching) - [ ] workflow file is commented so contributors understand each job ## Technical notes - ADR 0014. Runner: act_runner on LEISINGER with Docker — coordinate its availability with the repo owner (a note in the issue is enough; the runner installation itself is #9). ## Dependencies Depends on #1, #5, #6. **Size**: ~1 day --- *Conventions: English code/comments, clear human-readable code, no hard-coded UI strings (ADR 0012, add `de` **and** `en`), permission checks only via the shared guard (docs/architecture/permissions.md). Read the referenced ADRs before starting.*

fable-5 added this to the M0 — Walking skeleton milestone 2026-07-04 14:51:58 +02:00

fable-5 added the

deployment

label 2026-07-04 14:51:58 +02:00

fable-5 referenced this issue

2026-07-04 14:51:59 +02:00

CD workflow: build, push, deploy to Test, e2e smoke, promote to Int #8

fable-5 referenced this issue from a commit

2026-07-04 19:32:06 +02:00

Add CI workflow: lint, typecheck, tests, i18n check, image builds

fable-5 commented

2026-07-04 19:32:41 +02:00

Implementation landed in 9aa7b14 (.gitea/workflows/ci.yml): pnpm install with cache, workspace build, lint, typecheck, tests, i18n key parity, and build-only docker images for both Dockerfiles.

Still open: live verification of the red/green PR gate — requires the act_runner from #9 to be registered. Once the runner is online: open a throwaway PR with a failing test, confirm the red check blocks merging, then fix and confirm green.

Implementation landed in 9aa7b14 (`.gitea/workflows/ci.yml`): pnpm install with cache, workspace build, lint, typecheck, tests, i18n key parity, and build-only docker images for both Dockerfiles. **Still open:** live verification of the red/green PR gate — requires the act_runner from #9 to be registered. Once the runner is online: open a throwaway PR with a failing test, confirm the red check blocks merging, then fix and confirm green.

fable-5 referenced this issue

2026-07-05 00:32:05 +02:00

CI gate verification (do not merge) #97

fable-5 commented

2026-07-05 00:33:53 +02:00

Verified. Push pipeline runs green on main (commit 61da1cc: all six statuses success). Red-gate proof: PR #97 with a deliberately broken test went red within 40s; branch protection on main now requires the two CI contexts for PR merges (direct pushes whitelisted for stwaidele and fable-5 per the solo+agent workflow). The temporary PR was closed unmerged and its branch deleted.

**Verified.** Push pipeline runs green on main (commit 61da1cc: all six statuses success). Red-gate proof: PR #97 with a deliberately broken test went red within 40s; branch protection on `main` now requires the two CI contexts for PR merges (direct pushes whitelisted for stwaidele and fable-5 per the solo+agent workflow). The temporary PR was closed unmerged and its branch deleted.

fable-5 closed this issue

2026-07-05 00:33:53 +02:00

Sign in to join this conversation.