Merge and split table cells (#337) #342

Merged

fable-5 merged 1 commits from issue-337-merge-split into main 2026-08-16 05:21:44 +02:00

Conversation 0 Commits 1 Files Changed 9 +124 -1

fable-5 commented 2026-08-15 18:55:18 +02:00

Collaborator

Copy Link

prosemirror-tables already ships mergeCells/splitCell and the schema already carries colspan/rowspan -- only the controls were missing.

• two new toolbar buttons with selection-driven enabled states, labels de+en
• docToHtml now emits colspan/rowspan (read mode and HTML-based exports were silently dropping the merge)
• markdown serializer pads a colspan with empty cells so the exported table stays well-formed GFM; rowspan stays lossy there (the format cannot express it)
• unit tests for both serializers, e2e through the toolbar (merge, split, enabled states)

Stacked on #341 (fast-forward chain #340 -> #341 -> this).

Closes #337

prosemirror-tables already ships `mergeCells`/`splitCell` and the schema already carries colspan/rowspan -- only the controls were missing. - two new toolbar buttons with selection-driven enabled states, labels de+en - docToHtml now emits colspan/rowspan (read mode and HTML-based exports were silently dropping the merge) - markdown serializer pads a colspan with empty cells so the exported table stays well-formed GFM; rowspan stays lossy there (the format cannot express it) - unit tests for both serializers, e2e through the toolbar (merge, split, enabled states) Stacked on #341 (fast-forward chain #340 -> #341 -> this). Closes #337

fable-5 added 3 commits 2026-08-15 18:55:18 +02:00

Gap cursor for block-edge positions (#335) ... 69563348ca

A table (or any other block node without a text position of its own) as
the page's first, last, or only block was unreachable from before/after:
neither mouse nor arrow keys could place the cursor there, so no
paragraph could be created around it.

- add the prosemirror-gapcursor plugin as a TipTap extension (via
  @tiptap/pm, no new dependency; schema-neutral, so the editorSchema
  drift fence is unaffected)
- style the gap cursor bar in base.css -- the upstream package does not
  ship its stylesheet through our import path; the blink animation
  honors prefers-reduced-motion
- e2e: keyboard-only round trip that creates paragraphs before and
  after a lone table

Closes #335

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012aoPvnakfBP28nAfijgUY9

Unambiguous delete row/column toolbar icons (#336) ... b1165a37e6

The delete buttons paired the minus-box with a double arrow (bidirectional
arrows next to the symbol) which reads as "resize/expand", not "delete".
Replace them with axis stripes plus the x delete marker that deleteTable
already established: vertical stripes with x for delete column, horizontal
stripes with x for delete row. Labels/tooltips were correct all along and
stay unchanged.

Closes #336

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012aoPvnakfBP28nAfijgUY9

Merge and split table cells (#337) ... d76c731473

prosemirror-tables already ships mergeCells/splitCell and the schema
(tableNodes) already carries colspan/rowspan -- only the controls were
missing. Adds the two commands, toolbar buttons whose enabled state
follows the selection (merge needs a multi-cell selection, split a
merged cell), and de+en labels.

Both render paths now carry the spans: docToHtml emits colspan/rowspan
(read mode, exports via the HTML path), and the markdown serializer pads
a colspan with empty cells so every row keeps the table's column count
-- rowspan stays lossy there, GFM cannot express it.

e2e drives merge and split through the toolbar; the cell selection is
made per Shift+Click because a keypress in the same tick as the
preceding click races the editor's post-click rendering (keyboard cell
selection itself works, verified interactively with a settled editor).

Closes #337

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012aoPvnakfBP28nAfijgUY9

fable-5 referenced this pull request 2026-08-15 19:06:30 +02:00

Word-style Tab navigation in tables with an accessible exit (#338) #343

fable-5 referenced this pull request 2026-08-15 19:12:19 +02:00

Recognize Markdown tables on paste and while typing (#339) #344

fable-5 force-pushed issue-337-merge-split from d76c731473 to 3bf9363c34 2026-08-15 19:32:20 +02:00 Compare

fable-5 merged commit 3bf9363c34 into main 2026-08-16 05:21:44 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

  

area:docs

  

area:export

  

area:ops

  

area:storage

  

area:supply-chain

  

auth

Authentication, permissions, quotas

  

backend

API server (apps/api)

  

blocked

Blocked on external dependency/infrastructure

  

collab

Collaboration server (apps/collab)

  

deployment

Docker, CI/CD, hosting

  

docs

Documentation

  

effort:L

  

effort:M

  

effort:S

  

frontend

SPA (apps/web)

  

plugins

Plugin system and SDK

  

qa

Tests, fixtures, e2e

  

vs-nfd

  

vs-nfd:blocker

No Label

area:auth

area:docs

area:export

area:ops

area:storage

area:supply-chain

auth

backend

blocked

collab

deployment

docs

effort:L

effort:M

effort:S

frontend

plugins

qa

vs-nfd

vs-nfd:blocker

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stwaidele/dorfteich#342

No description provided.