stwaidele/dorfteich
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 22 Wiki Activity

Unambiguous delete row/column toolbar icons (#336)
Some checks failed
CI / Lint, typecheck, test (pull_request) Successful in 6m52s
Details
CI / Build container images (pull_request) Successful in 1m12s
Details
CI / Auth e2e pack (pull_request) Successful in 9m24s
Details
CI / Import/export fidelity gate (pull_request) Successful in 58s
Details
CD / Deploy to Test (push) Blocked by required conditions
Details
CD / Smoke tests against Test (push) Blocked by required conditions
Details
CD / Promote to Int (push) Blocked by required conditions
Details
CI / Auth e2e pack (push) Blocked by required conditions
Details
CI / Import/export fidelity gate (push) Blocked by required conditions
Details
CI / Build container images (push) Blocked by required conditions
Details
CD / Build and push images (push) Has been cancelled
Details
CI / Lint, typecheck, test (push) Has been cancelled
Details

Browse Source 
The delete buttons paired the minus-box with a double arrow (bidirectional
arrows next to the symbol) which reads as "resize/expand", not "delete".
Replace them with axis stripes plus the x delete marker that deleteTable
already established: vertical stripes with x for delete column, horizontal
stripes with x for delete row. Labels/tooltips were correct all along and
stay unchanged.

Closes #336

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012aoPvnakfBP28nAfijgUY9
This commit is contained in:
Claude Fable 5 2026-08-15 20:44:37 +02:00
parent 69563348ca
commit b1165a37e6
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
apps/web/src/editor/Toolbar.tsx
View File

@ -270,7 +270,10 @@ export function Toolbar({
disabled={!state.canDeleteColumn} disabled={!state.canDeleteColumn}
onClick={() => editor.chain().focus().deleteColumn().run()} onClick={() => editor.chain().focus().deleteColumn().run()}
> >
⊟↕ {/* Axis stripes + the × delete marker (already established by
deleteTable's ⊠): the earlier ⊟↕/⊟↔ double arrows read as
"resize/expand", not "delete" (issue #336). */}
▥×
</ToolbarButton> </ToolbarButton>
<ToolbarButton <ToolbarButton
label={t('toolbar.table.addRowBefore')} label={t('toolbar.table.addRowBefore')}
@ -291,7 +294,7 @@ export function Toolbar({
disabled={!state.canDeleteRow} disabled={!state.canDeleteRow}
onClick={() => editor.chain().focus().deleteRow().run()} onClick={() => editor.chain().focus().deleteRow().run()}
> >
⊟↔ ▤×
</ToolbarButton> </ToolbarButton>
<ToolbarButton <ToolbarButton
label={t('toolbar.table.toggleHeaderRow')} label={t('toolbar.table.toggleHeaderRow')}