Some checks failed
CD / Promote to Int (push) Blocked by required conditions
CD / Build and push images (push) Successful in 2m56s
CI / Lint, typecheck, test (push) Failing after 1m17s
CI / Auth e2e pack (push) Successful in 2m24s
CI / Build container images (push) Has been skipped
CD / Deploy to Test (push) Successful in 9s
CD / Smoke tests against Test (push) Has been cancelled
Update logs grow with every edit; compaction bounds storage and load time. - prisma: `collab_open_sessions` table (page_id, heartbeat_at) — the live-session registry that lets the compaction job avoid pages being edited, decoupled from collab (no api↔collab network call) and self- healing (a crashed collab's rows age out of the freshness window). - collab: `PostgresSessionRegistry` marks a page open on document load and closed on unload, and refreshes an every-30s heartbeat for all open docs; wired into the server hooks and started/stopped in index.ts. - api: `CompactionService` runs hourly via the shared scheduler (#31). For pages with > 500 log rows and no fresh session it merges `page_updates` into `ydoc_state` and deletes the merged rows in one FOR UPDATE transaction — atomic, so a mid-run crash leaves the page untouched and the next run resumes. Content is unchanged (merged state = base + all updates), so the content cache is left as-is; updated_at is deliberately not bumped. Metric log line with pages compacted / rows / bytes removed. Tests: DB-backed compaction test (content hash unchanged, below-threshold skipped, active session skipped then picked up next run, stale heartbeat ignored, idempotent); session-registry DB test (open/close, heartbeat refresh). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PGdhRiwU1WRL4XxJfZYipY
201 lines
7.5 KiB
TypeScript
201 lines
7.5 KiB
TypeScript
import { Server } from '@hocuspocus/server';
|
|
import { MAX_PAGE_DOCUMENT_BYTES } from '@dorfteich/shared';
|
|
import { verifyCollabToken } from '@dorfteich/shared/token-crypto';
|
|
import type { Logger } from 'pino';
|
|
|
|
import { buildHealthReport, isHealthRequest, type DatabaseProbe } from './health.js';
|
|
import type { PagePersistence } from './persistence.js';
|
|
import type { SessionRegistry } from './session-registry.js';
|
|
|
|
/** Per-connection context returned by onAuthenticate and used by later hooks. */
|
|
export interface CollabContext {
|
|
userId: string;
|
|
mode: 'rw' | 'ro';
|
|
}
|
|
|
|
export interface CollabServerDeps {
|
|
/** Version string surfaced in health responses (image build arg). */
|
|
version: string;
|
|
logger: Logger;
|
|
/** Secret shared with the api that signs the collaboration tokens (#34). */
|
|
tokenSecret: string;
|
|
/** Probe used by the `/healthz` endpoint. Injected so it is easy to test. */
|
|
pingDatabase: () => Promise<DatabaseProbe>;
|
|
/** Loads and persists page documents against PostgreSQL (#35). */
|
|
persistence: PagePersistence;
|
|
/**
|
|
* Advertises which pages have a live session so the compaction job skips
|
|
* them (#40). Optional: a server without it simply records no sessions,
|
|
* which keeps the unit/integration server tests free of a DB dependency.
|
|
*/
|
|
sessionRegistry?: SessionRegistry;
|
|
}
|
|
|
|
/**
|
|
* Stateless message the server broadcasts when a document exceeds the size
|
|
* ceiling on store: the client surfaces this and reverts the offending edit.
|
|
*/
|
|
export interface CollabErrorMessage {
|
|
type: 'error';
|
|
code: 'page_document_too_large';
|
|
limitBytes: number;
|
|
}
|
|
|
|
/**
|
|
* The Hocuspocus collaboration server (ADR 0003). It authenticates every
|
|
* connection with the api-minted token (#34) and is the writer of page state:
|
|
* `onLoadDocument` reconstructs the document from PostgreSQL and
|
|
* `onStoreDocument` persists it debounced, refreshing the derived content
|
|
* cache (#35).
|
|
*/
|
|
export function createCollabServer(deps: CollabServerDeps): Server {
|
|
const { version, logger, tokenSecret, pingDatabase, persistence, sessionRegistry } = deps;
|
|
|
|
return new Server({
|
|
name: 'dorfteich-collab',
|
|
// Suppress Hocuspocus' ASCII start screen; we emit our own pino logs.
|
|
quiet: true,
|
|
// index.ts owns graceful shutdown (it also closes the db pool); don't let
|
|
// Hocuspocus install its own signal handlers that would call process.exit.
|
|
stopOnSignals: false,
|
|
// Debounced persistence (realtime-collaboration.md §lifecycle): store 2 s
|
|
// after the last change, and at least every 30 s under continuous editing.
|
|
debounce: 2000,
|
|
maxDebounce: 30000,
|
|
|
|
/**
|
|
* Authorize every connection with the token the api minted after its own
|
|
* permission check (#34, ADR 0003). Rejecting (throwing) closes the socket.
|
|
* The document name is the page id, so a token issued for one page cannot
|
|
* open another. A `ro` token connects but its inbound document updates are
|
|
* dropped server-side via Hocuspocus' read-only connection flag.
|
|
*/
|
|
async onAuthenticate({ documentName, token, connectionConfig }): Promise<CollabContext> {
|
|
const result = verifyCollabToken(token, tokenSecret);
|
|
if (!result.valid) {
|
|
logger.info(
|
|
{ event: 'auth.rejected', documentName, reason: result.reason },
|
|
'collab authentication rejected',
|
|
);
|
|
throw new Error('unauthorized');
|
|
}
|
|
if (result.claims.pageId !== documentName) {
|
|
logger.info(
|
|
{ event: 'auth.rejected', documentName, reason: 'page_mismatch' },
|
|
'collab authentication rejected',
|
|
);
|
|
throw new Error('unauthorized');
|
|
}
|
|
|
|
if (result.claims.mode === 'ro') {
|
|
connectionConfig.readOnly = true;
|
|
}
|
|
logger.debug(
|
|
{ event: 'auth.ok', documentName, userId: result.claims.userId, mode: result.claims.mode },
|
|
'collab connection authenticated',
|
|
);
|
|
return { userId: result.claims.userId, mode: result.claims.mode };
|
|
},
|
|
|
|
async onConnect({ documentName, socketId }) {
|
|
logger.info(
|
|
{ event: 'connection.open', documentName, socketId },
|
|
'collaboration connection opened',
|
|
);
|
|
},
|
|
|
|
async onDisconnect({ documentName, socketId, clientsCount }) {
|
|
logger.info(
|
|
{ event: 'connection.close', documentName, socketId, clientsCount },
|
|
'collaboration connection closed',
|
|
);
|
|
},
|
|
|
|
/**
|
|
* Reconstruct the document from PostgreSQL (`ydoc_state` merged with the
|
|
* `page_updates` log) on first open. A page that no longer exists loads as
|
|
* an empty document; the token check already gates real access (#34).
|
|
*/
|
|
async onLoadDocument({ documentName, document }) {
|
|
const loaded = await persistence.loadInto(documentName, document);
|
|
// Advertise the open session so the compaction job skips this page (#40).
|
|
sessionRegistry?.markOpen(documentName);
|
|
logger.debug(
|
|
{ event: 'document.load', documentName, loaded },
|
|
loaded ? 'document loaded' : 'document not found, starting empty',
|
|
);
|
|
return document;
|
|
},
|
|
|
|
/**
|
|
* Persist the document (debounced by the config above) and refresh the
|
|
* derived `page_content_cache`. An oversize document is rejected without
|
|
* persisting and the offending clients are notified via a stateless
|
|
* message so they can revert (realtime-collaboration.md failure modes).
|
|
*/
|
|
async onStoreDocument({ documentName, document }) {
|
|
const result = await persistence.store(documentName, document);
|
|
if (result.outcome === 'too_large') {
|
|
const message: CollabErrorMessage = {
|
|
type: 'error',
|
|
code: 'page_document_too_large',
|
|
limitBytes: MAX_PAGE_DOCUMENT_BYTES,
|
|
};
|
|
document.broadcastStateless(JSON.stringify(message));
|
|
logger.warn(
|
|
{ event: 'document.store.rejected', documentName, bytes: result.bytes },
|
|
'document exceeds size ceiling; update not persisted',
|
|
);
|
|
return;
|
|
}
|
|
if (result.outcome === 'not_found') {
|
|
logger.warn(
|
|
{ event: 'document.store.skipped', documentName },
|
|
'document no longer exists; update not persisted',
|
|
);
|
|
return;
|
|
}
|
|
logger.debug(
|
|
{
|
|
event: 'document.store',
|
|
documentName,
|
|
bytes: result.bytes,
|
|
durationMs: Math.round(result.durationMs),
|
|
merged: result.merged,
|
|
},
|
|
'document persisted',
|
|
);
|
|
},
|
|
|
|
/** Drop the per-document store bookkeeping once Hocuspocus unloads it. */
|
|
async afterUnloadDocument({ documentName }) {
|
|
persistence.forget(documentName);
|
|
// The session ended; let the compaction job consider this page again (#40).
|
|
sessionRegistry?.markClosed(documentName);
|
|
},
|
|
|
|
async onRequest({ request, response }) {
|
|
if (!isHealthRequest(request.method, request.url)) {
|
|
// Not a health probe: let Hocuspocus handle the request.
|
|
return;
|
|
}
|
|
|
|
const database = await pingDatabase();
|
|
const { httpStatus, body } = buildHealthReport(version, database);
|
|
if (!database.ok) {
|
|
logger.warn(
|
|
{ event: 'health.failed', detail: database.detail },
|
|
'health check failed: database unreachable',
|
|
);
|
|
}
|
|
|
|
response.writeHead(httpStatus, { 'Content-Type': 'application/json' });
|
|
response.end(JSON.stringify(body));
|
|
|
|
// Hocuspocus sends a default 200 unless the onRequest chain rejects with
|
|
// a falsy reason; the response is already written, so stop the chain.
|
|
return Promise.reject();
|
|
},
|
|
});
|
|
}
|