Claude Opus 4.8
621aa47244
Some checks failed
CI / Auth e2e pack (push) Waiting to run
CI / Import/export fidelity gate (push) Waiting to run
CI / Build container images (push) Waiting to run
CD / Build and push images (push) Failing after 1m33s
CD / Deploy to Test (push) Has been skipped
CD / Smoke tests against Test (push) Has been skipped
CD / Promote to Int (push) Has been skipped
CI / Lint, typecheck, test (push) Has been cancelled
Backend for installing plugin ZIPs (ADR 0008, plugin-architecture.md §Lifecycle, security.md §Plugins). Consumes the #70 SDK for validation. - Schema: `plugins` (id, name, version, apiVersion, kind, mode, manifest jsonb, removedAt soft-delete) + `pond_plugins` (per-pond activation) + `PluginInstanceMode` enum; migration 20260710130000_plugins. - `PluginPackageService`: pure, stateless ZIP → validated package via fflate — structure check, manifest validation (SDK), apiVersion gate, kind/bundle/styles rules, CSS sanitation (no @import / external url() / expression()), zip-slip and unpacked-size guards. Each failure carries a stable PluginErrorCode; manifest issues travel as ApiError details. - `PluginStorageService`: on-disk layout `<PLUGINS_DIR>/<id>/<version>/`; atomic writeVersion (staging dir + rename, no 404 window mid-update), removeVersion/removePlugin, traversal-safe asset resolution, dropzone + quarantine dirs. - `PluginsService`: install/update (update only to a strictly higher version, preserving the admin's instance mode; files land before the metadata pointer flips) / uninstall (refused while required; soft-delete + files removed + pond activations dropped) / list / get. - `POST/GET/DELETE /admin/plugins` (SiteAdminGuard, multer memory upload), error→HTTP-status mapping. Public version-pinned static serving at `GET /plugins/:id/:version/*rest` with immutable cache + nosniff, only for the installed current version. - `PluginWatcherService`: watches `<PLUGINS_DIR>/_dropzone/`, runs the same validation, installs valid drops and quarantines invalid ones with the error logged; inert under NODE_ENV=test (tests drive processDropped). - SDK: `compareVersions`/`isHigherVersion`. shared: `PluginView`, `PluginInstanceMode`, `PLUGIN_ERROR_CODES`, `PLUGINS_DIR` env, plugin error i18n (de+en). Compose: `plugins` volume + `PLUGINS_DIR`. - Tests: package unit test (valid + each invalid class) and an e2e DB test (GUI install + immutable serving, non-admin 403, invalid-manifest details, dropzone install + quarantine, atomic higher-only update, required-guarded uninstall that removes files and tombstones metadata). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwZ4jR4KFAPvpjWevfUGX1
32 lines
1.1 KiB
TypeScript
32 lines
1.1 KiB
TypeScript
/**
|
|
* Version comparison for plugin manifests. Versions are validated by the
|
|
* manifest schema as `MAJOR.MINOR.PATCH`, so a numeric three-part compare is
|
|
* exact — no pre-release/build metadata to reason about in v1. The install flow
|
|
* (#71) uses this to accept an update only when the uploaded version is higher
|
|
* than the installed one.
|
|
*/
|
|
|
|
/** Splits a validated `x.y.z` string into its three numeric parts. */
|
|
function parts(version: string): [number, number, number] {
|
|
const [major = 0, minor = 0, patch = 0] = version.split('.').map((n) => Number.parseInt(n, 10));
|
|
return [major, minor, patch];
|
|
}
|
|
|
|
/** Returns -1 if `a` < `b`, 1 if `a` > `b`, 0 if equal. */
|
|
export function compareVersions(a: string, b: string): -1 | 0 | 1 {
|
|
const pa = parts(a);
|
|
const pb = parts(b);
|
|
for (let i = 0; i < 3; i += 1) {
|
|
const left = pa[i] ?? 0;
|
|
const right = pb[i] ?? 0;
|
|
if (left < right) return -1;
|
|
if (left > right) return 1;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
/** Whether `candidate` is a strictly higher version than `current`. */
|
|
export function isHigherVersion(candidate: string, current: string): boolean {
|
|
return compareVersions(candidate, current) > 0;
|
|
}
|