All checks were successful
CD / Build and push images (push) Successful in 3m54s
CD / Deploy to Test (push) Successful in 10s
CI / Lint, typecheck, test (push) Successful in 4m9s
CI / Build container images (push) Has been skipped
CD / Smoke tests against Test (push) Successful in 1m13s
CD / Promote to Int (push) Successful in 13s
CI / Auth e2e pack (push) Successful in 5m36s
CI / Import/export fidelity gate (push) Successful in 47s
A new block plugin bundling the OFFICIAL draw.io editor — nothing ever
loads from diagrams.net; the sandbox CSP pins every request to the
plugin's own version-pinned asset path (zero-external-network verified
live via a request-capture run).
Plugin (packages/plugins/drawio):
- block data { xml, svg }: xml is the draw.io source (document of
record), svg the rendered snapshot as raw markup — render mode,
office/PDF exports (the existing fallback renderer already inlines
data.svg) and the public view all show the diagram without running
diagram code
- edit mode: snapshot + "edit in fullscreen" (an empty block opens the
editor immediately); the bundled editor runs in a child iframe of the
plugin's own assets and speaks draw.io's JSON embed protocol —
Save & Exit exports xmlsvg, persists { xml, svg } via blockData, and
drops back to the inline size
- build.mjs fetches the pinned release (v30.3.6) into a gitignored
vendor/ cache (fonts-build pattern; skipped in CI — plugin.js still
bundles, the installable ZIP needs a dev machine) and packs a trimmed
webapp subset: no dev sources, no embed.diagrams.net integrations
bundle, no standalone viewers, no MathJax/templates/PWA — 27 MiB ZIP,
85 MiB unpacked, de+en editor languages
Host/SDK extensions (generic, not drawio-specific):
- new ui.enterFullscreen()/exitFullscreen(): the surface's frame becomes
a viewport-covering overlay — same sandboxed iframe, only geometry
changes; destroy removes the frame, so a vanished plugin can never
leave the app covered
- sandbox CSP: connect-src/frame-src now allow the plugin's OWN asset
path (was 'none') — bundled apps lazy-load their resources and run in
a child frame, but the api and external hosts stay unreachable; HTML
assets are served with the same CSP so a packaged page cannot widen
the rules, and child frames inherit the sandbox attribute
- plugin size limits raised (ZIP 5→64 MiB, unpacked 20→256 MiB) for
bundled-app plugins; content types for xml/txt/ico assets
Verified end to end against a local stack (9/9): install via dropzone
(85 MiB validation), block insert, fullscreen entry, bundled editor
boots inside the double sandbox (German UI), shape drawn, Save & Exit
persists, snapshot renders inline, survives reload, zero off-origin
requests throughout.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwZ4jR4KFAPvpjWevfUGX1
32 lines
1.2 KiB
TypeScript
32 lines
1.2 KiB
TypeScript
import type { PluginErrorCode } from '@dorfteich/shared';
|
|
|
|
/** Compressed upload ceiling for a plugin ZIP (multer rejects larger). */
|
|
// Raised for bundled-app plugins (drawio ships its whole editor as assets);
|
|
// still a hard bound against runaway uploads.
|
|
export const MAX_PLUGIN_ZIP_BYTES = 64 * 1024 * 1024; // 64 MiB
|
|
|
|
/** Total decompressed ceiling — guards against a zip bomb inflating in memory. */
|
|
export const MAX_PLUGIN_UNPACKED_BYTES = 256 * 1024 * 1024; // 256 MiB
|
|
|
|
/** The two files the package structure hinges on. */
|
|
export const MANIFEST_FILE = 'manifest.json';
|
|
export const CODE_BUNDLE_FILE = 'plugin.js';
|
|
export const STYLES_FILE = 'styles.css';
|
|
|
|
/**
|
|
* A rejected install/uninstall, carrying a stable {@link PluginErrorCode} and,
|
|
* for manifest failures, the field-level issues to surface in the API error
|
|
* body `details`. Thrown by the package/registry services; the controller maps
|
|
* it to the matching HTTP status.
|
|
*/
|
|
export class PluginPackageError extends Error {
|
|
constructor(
|
|
readonly code: PluginErrorCode,
|
|
message: string,
|
|
readonly details?: Record<string, string[]>,
|
|
) {
|
|
super(message);
|
|
this.name = 'PluginPackageError';
|
|
}
|
|
}
|