Claude Fable 5
0c6494f209
All checks were successful
CD / Build and push images (push) Successful in 2m54s
CI / Lint, typecheck, test (push) Successful in 2m25s
CI / Auth e2e pack (push) Successful in 2m58s
CI / Build container images (push) Has been skipped
CD / Deploy to Test (push) Successful in 9s
CD / Smoke tests against Test (push) Successful in 1m12s
CD / Promote to Int (push) Successful in 12s
Every route now declares its access rule explicitly and is enforced through the shared resolution algorithm (permissions.md): - PermissionGuard + decorators (@RequiresPondRole, @RequiresPagePermission, @RequiresAttachmentPermission, @AuthenticatedOnly) applied to every route; a route-enumeration test proves full coverage alongside @Public()/Site-Admin-guarded routes. - 404/403 policy (documented in README conventions): denied reads answer 404 (existence hiding), denied writes on readable things answer 403; trash views need write capability (ADR 0013). - PermissionService resolves page/pond questions via the shared resolver, with an in-process pond-context cache (grants + label parents) that is invalidated on every grant/label-tree change and TTL-bounded as a multi-process safety net. Grant changes also fire pond_access_changed for collab revalidation (#39/#53). - shared: pond-scope resolution (hasPondRole, canSeePond) next to the page resolver; grant wire schemas + GrantView. - Owner Pond-Admin grants: migration backfill for all existing ponds, created transactionally with every new pond (shared + personal + seed). - Grant CRUD under /ponds/:id/grants (pond_admin-gated) with structural and referential validation, last-admin protection, audit logs. - InterimAccessService deleted; page lists, search, backlinks, phantom links, and trash listings are filtered per page through the resolver; collab tokens are now truly ro for readers. - Fixture-matrix e2e (reader/editor/pond admin/foreign, label-deny, authenticated-subject, revoke-then-immediate-deny cache test). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PGdhRiwU1WRL4XxJfZYipY
30 lines
1.2 KiB
TypeScript
30 lines
1.2 KiB
TypeScript
import { Controller, Get, Param, Req } from '@nestjs/common';
|
|
import { BacklinkView, PhantomLinkView } from '@dorfteich/shared';
|
|
|
|
import { AuthedRequest } from '../auth/auth.guard';
|
|
import { RequiresPagePermission, RequiresPondRole } from '../permissions/permission.decorators';
|
|
import { LinksService } from './links.service';
|
|
|
|
/** Wikilink index reads (issue #47): backlinks and a pond's phantom links. */
|
|
@Controller()
|
|
export class LinksController {
|
|
constructor(private readonly links: LinksService) {}
|
|
|
|
/** Pages that link to this page (permission-filtered). */
|
|
@Get('pages/:id/backlinks')
|
|
@RequiresPagePermission('read', { idParam: 'id' }) // sources are filtered per page
|
|
async backlinks(@Param('id') id: string, @Req() request: AuthedRequest): Promise<BacklinkView[]> {
|
|
return this.links.backlinks(request.user!, id);
|
|
}
|
|
|
|
/** Referenced-but-missing pages in the pond, with their referrers. */
|
|
@Get('ponds/:pondId/phantom-links')
|
|
@RequiresPondRole('reader', { idParam: 'pondId' }) // referrers are filtered per page
|
|
async phantomLinks(
|
|
@Param('pondId') pondId: string,
|
|
@Req() request: AuthedRequest,
|
|
): Promise<PhantomLinkView[]> {
|
|
return this.links.phantomLinks(request.user!, pondId);
|
|
}
|
|
}
|