Claude Fable 5
0c6494f209
All checks were successful
CD / Build and push images (push) Successful in 2m54s
CI / Lint, typecheck, test (push) Successful in 2m25s
CI / Auth e2e pack (push) Successful in 2m58s
CI / Build container images (push) Has been skipped
CD / Deploy to Test (push) Successful in 9s
CD / Smoke tests against Test (push) Successful in 1m12s
CD / Promote to Int (push) Successful in 12s
Every route now declares its access rule explicitly and is enforced through the shared resolution algorithm (permissions.md): - PermissionGuard + decorators (@RequiresPondRole, @RequiresPagePermission, @RequiresAttachmentPermission, @AuthenticatedOnly) applied to every route; a route-enumeration test proves full coverage alongside @Public()/Site-Admin-guarded routes. - 404/403 policy (documented in README conventions): denied reads answer 404 (existence hiding), denied writes on readable things answer 403; trash views need write capability (ADR 0013). - PermissionService resolves page/pond questions via the shared resolver, with an in-process pond-context cache (grants + label parents) that is invalidated on every grant/label-tree change and TTL-bounded as a multi-process safety net. Grant changes also fire pond_access_changed for collab revalidation (#39/#53). - shared: pond-scope resolution (hasPondRole, canSeePond) next to the page resolver; grant wire schemas + GrantView. - Owner Pond-Admin grants: migration backfill for all existing ponds, created transactionally with every new pond (shared + personal + seed). - Grant CRUD under /ponds/:id/grants (pond_admin-gated) with structural and referential validation, last-admin protection, audit logs. - InterimAccessService deleted; page lists, search, backlinks, phantom links, and trash listings are filtered per page through the resolver; collab tokens are now truly ro for readers. - Fixture-matrix e2e (reader/editor/pond admin/foreign, label-deny, authenticated-subject, revoke-then-immediate-deny cache test). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PGdhRiwU1WRL4XxJfZYipY
36 lines
1.3 KiB
TypeScript
36 lines
1.3 KiB
TypeScript
import { BadRequestException, Controller, Get, Query, Req } from '@nestjs/common';
|
|
import { SearchQuery, SearchResultView, searchQuerySchema } from '@dorfteich/shared';
|
|
|
|
import { AuthedRequest } from '../auth/auth.guard';
|
|
import { AuthenticatedOnly } from '../permissions/permission.decorators';
|
|
import { SearchProvider } from './search.provider';
|
|
|
|
/** Full-text search (issue #49, ADR 0010). */
|
|
@Controller()
|
|
export class SearchController {
|
|
constructor(private readonly search: SearchProvider) {}
|
|
|
|
/**
|
|
* `GET /search?q=…&pondId=…&labels=a,b` — ranked, permission-filtered hits.
|
|
* `labels` is a comma-separated list; scope defaults to all readable ponds.
|
|
*/
|
|
@Get('search')
|
|
@AuthenticatedOnly() // results are permission-filtered inside the provider
|
|
async query(
|
|
@Query('q') q: string,
|
|
@Query('pondId') pondId: string | undefined,
|
|
@Query('labels') labels: string | undefined,
|
|
@Req() request: AuthedRequest,
|
|
): Promise<SearchResultView[]> {
|
|
const parsed = searchQuerySchema.safeParse({
|
|
q,
|
|
pondId: pondId || undefined,
|
|
labels: labels ? labels.split(',').filter(Boolean) : undefined,
|
|
} satisfies Record<string, unknown>);
|
|
if (!parsed.success) {
|
|
throw new BadRequestException({ code: 'bad_request' });
|
|
}
|
|
return this.search.search(parsed.data as SearchQuery, request.user!);
|
|
}
|
|
}
|