A11y: ARIA-Semantik (#164) und Reflow 320px (#165) #173

Merged
stwaidele merged 2 commits from a11y-aria into main 2026-07-21 16:29:20 +02:00
11 changed files with 100 additions and 10 deletions

View File

@ -121,7 +121,7 @@ export function MentionAutocomplete({ editor }: { editor: Editor }): React.JSX.E
style={{ position: 'fixed', left: state.coords.left, top: state.coords.bottom + 4 }}
>
{suggestions.map((user, index) => (
<li key={user.id}>
<li key={user.id} role="presentation">
<button
type="button"
role="option"

View File

@ -80,6 +80,22 @@ function ImageInsertButton({
);
}
/** Arrow-key navigation between toolbar controls (#164, role="toolbar"
* convention). Native selects keep their own arrow-key handling. */
function onToolbarArrowKey(event: React.KeyboardEvent<HTMLDivElement>): void {
if (event.key !== 'ArrowRight' && event.key !== 'ArrowLeft') return;
const target = event.target as HTMLElement;
if (target.tagName === 'SELECT' || target.tagName === 'INPUT') return;
const controls = [
...event.currentTarget.querySelectorAll<HTMLElement>('button:not([disabled]), select'),
];
const index = controls.indexOf(target);
if (index === -1) return;
event.preventDefault();
const step = event.key === 'ArrowRight' ? 1 : -1;
controls[(index + step + controls.length) % controls.length]?.focus();
}
/** Keyboard-accessible toolbar for the page editor (issue #25). Table row/
* column controls stay visible but disabled outside a table, so the
* toolbar's layout and tab order never shift while typing. */
@ -118,7 +134,12 @@ export function Toolbar({
});
return (
<div className="editor-toolbar" role="toolbar" aria-label={t('toolbar.paragraph')}>
<div
className="editor-toolbar"
role="toolbar"
aria-label={t('toolbar.label')}
onKeyDown={onToolbarArrowKey}
>
<div className="editor-toolbar__group">
<ToolbarButton
label={t('toolbar.paragraph')}

View File

@ -158,7 +158,7 @@ export function WikilinkAutocomplete({ editor }: { editor: Editor }): React.JSX.
style={{ position: 'fixed', left: state.coords.left, top: state.coords.bottom + 4 }}
>
{suggestions.map((item, index) => (
<li key={`${item.kind}:${item.slug}`}>
<li key={`${item.kind}:${item.slug}`} role="presentation">
<button
type="button"
role="option"

View File

@ -64,7 +64,10 @@ export function AppLayout(): React.JSX.Element {
<Sidebar collapsed={collapsed} />
{!collapsed && <SidebarResizer widthRem={widthRem} onResize={setSidebarWidth} />}
<div className="main-column">
<main className="main">
{/* tabIndex: the main area is the app's scroll container; on
pages without focusable content (e.g. legal texts) keyboard
users could otherwise not scroll it (#165, WCAG 2.1.1). */}
<main className="main" tabIndex={0}>
<Outlet />
</main>
{/* Outside the scroll container: always visible at the bottom

View File

@ -64,6 +64,7 @@ export function Sidebar({ collapsed }: SidebarProps): React.JSX.Element {
<nav
className={collapsed ? 'sidebar sidebar--collapsed' : 'sidebar'}
aria-hidden={collapsed}
inert={collapsed}
aria-label={t('layout.sidebar.label')}
>
{!pond.data ? (

View File

@ -96,7 +96,8 @@ export function TopBar({ sidebarCollapsed, onToggleSidebar }: TopBarProps): Reac
onClick={() => setSearchOpen(true)}
aria-label={t('search:open')}
>
<Search aria-hidden /> {t('search:open')}
<Search aria-hidden />
<span className="topbar__search-text">{t('search:open')}</span>
</button>
)}
{searchOpen && user && <SearchPalette onClose={() => setSearchOpen(false)} />}

View File

@ -209,7 +209,19 @@ function PageEditor({
useLayoutEffect(() => {
editor?.setEditable(canEdit);
}, [editor, canEdit]);
// TipTap rendert die Fläche als role="textbox" — ohne Namen, und im
// Lesemodus ist "Textfeld" schlicht falsch (#164, WCAG 4.1.2). Im
// Lesemodus wird sie zum benannten Dokument-Bereich.
editor?.setOptions({
editorProps: {
attributes: {
role: canEdit ? 'textbox' : 'document',
'aria-label': t('contentLabel'),
...(canEdit ? { 'aria-multiline': 'true' } : {}),
},
},
});
}, [editor, canEdit, t]);
// Entering edit mode drops the caret straight into the content, so writing
// starts without an extra — and on empty pages pixel-precise — click. Skip

View File

@ -208,7 +208,7 @@ export function SearchPalette({ onClose }: { onClose: () => void }): React.JSX.E
) : (
<ul className="search-results" role="listbox" aria-label={t('resultsLabel')}>
{hits.map((hit, index) => (
<li key={hit.pageId}>
<li key={hit.pageId} role="presentation">
<button
type="button"
role="option"

View File

@ -53,7 +53,9 @@ button {
/* Layout skeleton */
.app {
display: grid;
grid-template-rows: var(--topbar-height) 1fr;
/* minmax: the topbar row may grow when its controls wrap on narrow
viewports (issue #165, WCAG 1.4.10). */
grid-template-rows: minmax(var(--topbar-height), auto) 1fr;
height: 100%;
}
@ -70,6 +72,10 @@ button {
align-items: center;
gap: var(--space-4);
padding: 0 var(--space-4);
/* Same #100 pattern as .app-body: without this the topbar's min-content
width sizes the shared grid column and forces page-level horizontal
scrolling on narrow viewports (issue #165, WCAG 1.4.10). */
min-width: 0;
border-bottom: 1px solid var(--color-border);
background: var(--color-bg);
/* Own stacking context above the scrolling `.main` content: the nav comes
@ -91,6 +97,39 @@ button {
flex: 1;
}
/* Narrow viewports (issue #165, WCAG 1.4.10): the topbar wraps onto a
second row instead of pushing the page wider than the viewport; every
control stays visible and reachable. The search button drops to its
icon (the aria-label carries the name). The expanded sidebar becomes
an overlay above the content 256 px beside a 320 px viewport would
leave the content a sliver and force page-level horizontal scrolling. */
@media (max-width: 40rem) {
.topbar {
flex-wrap: wrap;
row-gap: 0;
padding: var(--space-1) var(--space-2);
}
.topbar__search-text {
display: none;
}
.app-body {
position: relative;
}
.sidebar:not(.sidebar--collapsed) {
position: absolute;
inset: 0 auto 0 0;
z-index: 25;
box-shadow: 2px 0 8px rgb(0 0 0 / 0.15);
}
.sidebar-resizer {
display: none;
}
}
.sidebar {
width: var(--sidebar-width);
flex-shrink: 0;
@ -715,6 +754,9 @@ button {
align-items: center;
gap: var(--space-2);
flex-shrink: 0;
/* Wrap instead of widening the page on narrow viewports (#165). */
flex-wrap: wrap;
min-width: 0;
padding: var(--space-2) var(--space-8);
border-top: 1px solid var(--color-border);
background: var(--color-bg);
@ -958,6 +1000,9 @@ button {
.editor-page__title {
flex: 1;
/* An input's intrinsic size-attribute width must not set the page's
minimum width on narrow viewports (#165). */
min-width: 0;
border: none;
background: none;
font-family: var(--font-heading);
@ -3784,6 +3829,9 @@ ul[data-type='task_list'] li p:last-of-type {
@media (max-width: 60rem) {
.settings-layout {
flex-direction: column;
/* Override the row layout's flex-start: stacked, the content column
must stretch to the viewport instead of its widest control (#165). */
align-items: stretch;
}
.settings-nav {

View File

@ -38,6 +38,7 @@
"discardConfirm": "Die auf diesem Gerät gespeicherten Änderungen verwerfen? Das kann nicht rückgängig gemacht werden."
},
"toolbar": {
"label": "Formatierung",
"paragraph": "Absatz",
"heading1": "Überschrift 1",
"heading2": "Überschrift 2",
@ -189,5 +190,6 @@
"dateMarker": {
"due": "Zieldatum",
"start": "Startdatum"
}
},
"contentLabel": "Seiteninhalt"
}

View File

@ -38,6 +38,7 @@
"discardConfirm": "Discard the changes saved on this device? This cannot be undone."
},
"toolbar": {
"label": "Formatting",
"paragraph": "Paragraph",
"heading1": "Heading 1",
"heading2": "Heading 2",
@ -189,5 +190,6 @@
"dateMarker": {
"due": "Due date",
"start": "Start date"
}
},
"contentLabel": "Page content"
}