Link UX: edit URL and open in new tab #29

New Issue

fable-5 · 2026-07-04T14:52:11+02:00

fable-5 commented

2026-07-04 14:52:11 +02:00

Context

Vision requirement: in edit mode, URLs offer 'edit URL' and 'open in new browser tab'.

Scope

Link workflows: set/edit link via toolbar and Cmd/Ctrl-K, bubble menu on link selection with actions 'edit URL', 'open in new tab' (noopener), 'remove link'; URL validation against the protocol allowlist; paste-over-selection with a URL creates a link.

Acceptance criteria

all bubble-menu actions work in edit mode; open-in-new-tab also works in read mode
invalid protocols (javascript:) are rejected with a localized hint
pasting a URL over selected text links it (e2e)

Technical notes

ADR 0004, security.md (protocol allowlist lives in the shared schema #24).

Dependencies

Depends on #25.

Size: ~0.5 day

Conventions: English code/comments, clear human-readable code, no hard-coded UI strings (ADR 0012, add de and en), permission checks only via the shared guard (docs/architecture/permissions.md). Read the referenced ADRs before starting.

## Context Vision requirement: in edit mode, URLs offer 'edit URL' and 'open in new browser tab'. ## Scope Link workflows: set/edit link via toolbar and Cmd/Ctrl-K, bubble menu on link selection with actions 'edit URL', 'open in new tab' (noopener), 'remove link'; URL validation against the protocol allowlist; paste-over-selection with a URL creates a link. ## Acceptance criteria - [ ] all bubble-menu actions work in edit mode; open-in-new-tab also works in read mode - [ ] invalid protocols (javascript:) are rejected with a localized hint - [ ] pasting a URL over selected text links it (e2e) ## Technical notes - ADR 0004, security.md (protocol allowlist lives in the shared schema #24). ## Dependencies Depends on #25. **Size**: ~0.5 day --- *Conventions: English code/comments, clear human-readable code, no hard-coded UI strings (ADR 0012, add `de` **and** `en`), permission checks only via the shared guard (docs/architecture/permissions.md). Read the referenced ADRs before starting.*

fable-5 added this to the M2 — Ponds & pages, single-user editing milestone 2026-07-04 14:52:11 +02:00

fable-5 added the

frontend

label 2026-07-04 14:52:11 +02:00

sonnet-5 referenced this issue from a commit

2026-07-08 11:50:43 +02:00

Add link UX: edit URL and open in new tab (#29)

sonnet-5 closed this issue

2026-07-08 11:50:43 +02:00

sonnet-5 commented

2026-07-08 12:04:47 +02:00

Implemented in b5cc4c3 and closed via Closes #29. Pipeline verification for that commit:

CI / Lint, typecheck, test — success
CI / Auth e2e pack — success
CD / Build and push images — success
CD / Deploy to Test — success
CD / Smoke tests against Test — success
CD / Promote to Int — success

Acceptance criteria covered by apps/web/e2e/link.spec.ts (run locally against the dev stack): toolbar/Mod-k create+edit a link, bubble-menu edit/open-in-new-tab/remove all work in edit mode, read mode opens links in a new tab by default (target=_blank), invalid protocols show a localized inline error instead of applying, and pasting a URL over a selection links the selected text.

Implemented in b5cc4c3 and closed via `Closes #29`. Pipeline verification for that commit: - CI / Lint, typecheck, test — success - CI / Auth e2e pack — success - CD / Build and push images — success - CD / Deploy to Test — success - CD / Smoke tests against Test — success - CD / Promote to Int — success Acceptance criteria covered by `apps/web/e2e/link.spec.ts` (run locally against the dev stack): toolbar/Mod-k create+edit a link, bubble-menu edit/open-in-new-tab/remove all work in edit mode, read mode opens links in a new tab by default (`target=_blank`), invalid protocols show a localized inline error instead of applying, and pasting a URL over a selection links the selected text.

Sign in to join this conversation.