#288: reset schema before pg_restore — partitioned tables broke --clean #289

fable-5 · 2026-07-31T17:00:24+02:00

fable-5 commented

2026-07-31 17:00:24 +02:00

Fixes #288 (found during the isolated deployment run, #220).

pg_restore --clean --if-exists emitted DROP CONSTRAINT for the per-partition primary keys of read_events (partitioned since #224); PostgreSQL refuses to drop inherited constraints, so the restore exited non-zero and was reported FAILED although the content was restored correctly.

Change: drop and recreate the public schema before pg_restore (the database holds no extension objects outside pg_catalog). All --clean drops become no-ops (kept as belt and braces), and the restore becomes faithful — objects created after the backup no longer survive it. Runbook docs updated accordingly.

Verified in the isolated environment of #220: restore of set 20260731-132200 exits 0, a deliberately created post-backup table is gone, page content and all read_events partitions intact, /readyz fully green after api restart.

Do not merge before the issue is closed manually — merge on green CI only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AUtYMxwTCMHG9mVHnwbFg8

Fixes #288 (found during the isolated deployment run, #220). `pg_restore --clean --if-exists` emitted `DROP CONSTRAINT` for the per-partition primary keys of `read_events` (partitioned since #224); PostgreSQL refuses to drop inherited constraints, so the restore exited non-zero and was reported FAILED although the content was restored correctly. **Change**: drop and recreate the `public` schema before `pg_restore` (the database holds no extension objects outside `pg_catalog`). All `--clean` drops become no-ops (kept as belt and braces), and the restore becomes faithful — objects created after the backup no longer survive it. Runbook docs updated accordingly. **Verified** in the isolated environment of #220: restore of set `20260731-132200` exits 0, a deliberately created post-backup table is gone, page content and all `read_events` partitions intact, `/readyz` fully green after api restart. Do not merge before the issue is closed manually — merge on green CI only. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01AUtYMxwTCMHG9mVHnwbFg8

fable-5 added 1 commit 2026-07-31 17:00:24 +02:00

#288 : reset schema before pg_restore — partitioned tables broke --clean

CI / Lint, typecheck, test (pull_request) Successful in 6m48s

Details

CI / Build container images (pull_request) Successful in 1m46s

Details

CI / Auth e2e pack (pull_request) Successful in 8m22s

Details

CI / Import/export fidelity gate (pull_request) Successful in 1m8s

Details

CD / Deploy to Test (push) Blocked by required conditions

Details

CD / Smoke tests against Test (push) Blocked by required conditions

Details

CD / Promote to Int (push) Blocked by required conditions

Details

CI / Auth e2e pack (push) Blocked by required conditions

Details

CI / Import/export fidelity gate (push) Blocked by required conditions

Details

CI / Build container images (push) Blocked by required conditions

Details

CD / Build and push images (push) Has been cancelled

Details

CI / Lint, typecheck, test (push) Has been cancelled

Details

4f6596e8a2

Since #224 read_events is partitioned; the dump carries per-partition
primary keys as own entries, and pg_restore --clean emitted DROP
CONSTRAINT against inherited constraints, which PostgreSQL refuses. The
restore then reported FAILED although the content was restored. Dropping
and recreating the public schema first makes every --clean drop a no-op
and the restore faithful: objects created after the backup no longer
survive. Verified in the isolated environment of #220 (set
20260731-132200, exit 0, readyz green).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AUtYMxwTCMHG9mVHnwbFg8

fable-5 referenced this pull request

2026-07-31 17:05:24 +02:00

#220: protocol of the isolated deployment run #290

fable-5 merged commit 4f6596e8a2 into main

2026-07-31 17:24:18 +02:00

fable-5 referenced this pull request

2026-07-31 17:27:42 +02:00

Restore reports failure on partitioned tables: pg_restore --clean cannot drop inherited partition PKs #288

fable-5 referenced this pull request

2026-07-31 17:27:42 +02:00

[VS-NfD] Run and document a deployment in a network-isolated environment #220

Sign in to join this conversation.