#234: retention for mail_outbox #255

Merged

fable-5 merged 1 commits from feat/234-mail-outbox-retention into main 2026-07-30 23:10:35 +02:00

Conversation 0 Commits 1 Files Changed 8 +199 -5

fable-5 commented 2026-07-30 22:17:45 +02:00

Collaborator

Copy Link

Stacked on #254 (#233) — after its fast-forward merge this PR reduces to one commit. Issue #234 is closed manually after green CI/CD per process.

• New daily scheduled job mail-outbox-retention: deletes SENT rows (by sentAt) and permanently FAILED rows (by nextAttemptAt) past mail.outboxRetentionDays (new instance setting, default 30).
• PENDING rows — including failed-but-retryable ones — are untouched; the retry loop stays the sole owner (asserted by test).
• Decision on digest titles recorded in security.md §Privacy (+ residual-risk comment for #231): titles stay for now — no per-page classification marking exists yet to key a suppression on (ADR 0022 / M32 revisits); a VS-NfD reference configuration can leave SMTP unconfigured.
• Tests: mail-outbox-retention.e2e.db.test.ts; full api suite green (473) against fresh DB.
• Docs: operations.md job table; plan checkbox I-23. system.spec job-count fence 8 -> 9.

Stacked on #254 (#233) — after its fast-forward merge this PR reduces to one commit. Issue #234 is closed manually after green CI/CD per process. - New daily scheduled job `mail-outbox-retention`: deletes SENT rows (by sentAt) and permanently FAILED rows (by nextAttemptAt) past `mail.outboxRetentionDays` (new instance setting, default 30). - PENDING rows — including failed-but-retryable ones — are untouched; the retry loop stays the sole owner (asserted by test). - Decision on digest titles recorded in security.md §Privacy (+ residual-risk comment for #231): titles stay for now — no per-page classification marking exists yet to key a suppression on (ADR 0022 / M32 revisits); a VS-NfD reference configuration can leave SMTP unconfigured. - Tests: `mail-outbox-retention.e2e.db.test.ts`; full api suite green (473) against fresh DB. - Docs: operations.md job table; plan checkbox I-23. system.spec job-count fence 8 -> 9.

fable-5 added 2 commits 2026-07-30 22:17:45 +02:00

#233: prune conversion job payloads for every job kind ... ff505bc752

The raw input/result bytes of import/export conversion jobs were kept
forever; a deleted classified page could live on inside its last export.
A new daily conversion-payload-prune job nulls both once a finished
(succeeded or failed) job passes conversion.payloadRetentionDays
(instance setting, default 30) — the row survives for status/audit.
PENDING and RUNNING rows keep their payload, so the worker's stale-lock
recovery path is untouched; a hand-requeued pruned job fails finally
via conversionInputOf instead of crashing the worker.

The input column becomes nullable; the migration backfills by clearing
payloads of jobs already finished longer ago than the default period
(recent results stay downloadable until they age out).

Job-count fence in system.spec: 7 -> 8 (new scheduler registration).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0168Ph5uBmHm8X28CSVpbpnJ

#234: retention for mail_outbox ... 69d9072d2c

Sent mails were kept forever, and digest bodies name page titles and
actors — an unbounded copy of content-adjacent data. A new daily
mail-outbox-retention job deletes SENT rows (by sentAt) and permanently
FAILED rows (by nextAttemptAt, the last attempt's stamp) once they pass
mail.outboxRetentionDays (instance setting, default 30). PENDING rows —
including failed-but-retryable ones — stay the retry loop's alone.

Decision recorded (security.md §Privacy, residual-risk note for #231):
digest mails keep carrying page titles for now — there is no per-page
classification marking yet to key a suppression on (ADR 0022 / M32
revisits), and a VS-NfD reference configuration can leave SMTP
unconfigured entirely.

Job-count fence in system.spec: 8 -> 9.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0168Ph5uBmHm8X28CSVpbpnJ

fable-5 referenced this pull request 2026-07-30 22:18:49 +02:00

#235: keep page_links rows pointing at purged pages (recorded decision) #256

fable-5 referenced this pull request 2026-07-30 22:20:56 +02:00

[VS-NfD] Maintain the residual-risk list #231

fable-5 merged commit 69d9072d2c into main 2026-07-30 23:10:35 +02:00

fable-5 referenced this pull request 2026-07-30 23:11:09 +02:00

[VS-NfD] Add retention for `mail_outbox` #234

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

  

area:docs

  

area:export

  

area:ops

  

area:storage

  

area:supply-chain

  

auth

Authentication, permissions, quotas

  

backend

API server (apps/api)

  

blocked

Blocked on external dependency/infrastructure

  

collab

Collaboration server (apps/collab)

  

deployment

Docker, CI/CD, hosting

  

docs

Documentation

  

effort:L

  

effort:M

  

effort:S

  

frontend

SPA (apps/web)

  

plugins

Plugin system and SDK

  

qa

Tests, fixtures, e2e

  

vs-nfd

  

vs-nfd:blocker

No Label

area:auth

area:docs

area:export

area:ops

area:storage

area:supply-chain

auth

backend

blocked

collab

deployment

docs

effort:L

effort:M

effort:S

frontend

plugins

qa

vs-nfd

vs-nfd:blocker

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stwaidele/dorfteich#255

No description provided.