Commit Graph

4 Commits

Author SHA1 Message Date
30992a2e6d Actually drop the quota override from the comments pack (#92)
All checks were successful
CD / Build and push images (push) Successful in 1m8s
CD / Deploy to Test (push) Successful in 10s
CD / Smoke tests against Test (push) Successful in 1m9s
CD / Promote to Int (push) Successful in 10s
CI / Lint, typecheck, test (push) Successful in 3m18s
CI / Build container images (push) Has been skipped
CI / Auth e2e pack (push) Successful in 5m24s
CI / Import/export fidelity gate (push) Successful in 46s
The previous commit's automated edit silently missed the beforeAll block;
the pack still lowered the seeded additional_ponds override to 10, which
CI's accumulated fixture ponds exceed. The pack now relies on the seeded
headroom and reports the create-pond response on failure.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwZ4jR4KFAPvpjWevfUGX1
2026-07-11 22:36:53 +02:00
c8afe7c8d6 Do not lower the seeded pond quota in the comments pack (#92)
Some checks failed
CD / Build and push images (push) Successful in 1m6s
CD / Deploy to Test (push) Successful in 9s
CD / Smoke tests against Test (push) Successful in 1m9s
CD / Promote to Int (push) Successful in 10s
CI / Lint, typecheck, test (push) Successful in 3m19s
CI / Build container images (push) Has been skipped
CI / Auth e2e pack (push) Failing after 2m44s
CI / Import/export fidelity gate (push) Has been skipped
The seed already grants fixture users additional_ponds headroom (100);
overriding it down to 10 made pond creation fail in CI, where the
earlier packs' ponds count against the limit. The pack now relies on
the seeded override and reports the create-pond response on failure.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwZ4jR4KFAPvpjWevfUGX1
2026-07-11 22:28:56 +02:00
c7d3b20ca0 Isolate the comments e2e pack in its own pond (#92)
Some checks failed
CD / Build and push images (push) Successful in 1m5s
CD / Deploy to Test (push) Successful in 10s
CD / Smoke tests against Test (push) Successful in 1m10s
CD / Promote to Int (push) Successful in 10s
CI / Lint, typecheck, test (push) Successful in 3m17s
CI / Build container images (push) Has been skipped
CI / Auth e2e pack (push) Failing after 2m45s
CI / Import/export fidelity gate (push) Has been skipped
The shared fixture pond accumulates grants from earlier packs in the
same CI job, so "fixture-editor is only a reader" did not hold there and
the policy test failed in CI while passing locally. A Site Admin now
lifts fixture-user's additional-pond quota for the run, the pack
provisions a fresh pond and page, and tears both down afterwards; the
policy PATCH is also asserted.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwZ4jR4KFAPvpjWevfUGX1
2026-07-11 22:17:47 +02:00
e54aaf76f9 Add the comments panel, unread badge, and comment-policy setting (#92)
Some checks failed
CI / Lint, typecheck, test (push) Successful in 3m21s
CI / Build container images (push) Has been skipped
CD / Build and push images (push) Successful in 3m43s
CD / Deploy to Test (push) Successful in 12s
CD / Smoke tests against Test (push) Successful in 1m12s
CD / Promote to Int (push) Successful in 10s
CI / Auth e2e pack (push) Failing after 3m1s
CI / Import/export fidelity gate (push) Has been skipped
New comments panel on the page (toggle next to attachments, unread badge
counting comments newer than the last localStorage-recorded visit):
threaded display with relative times and author names, a Markdown
composer with hints, edit/delete for authors, resolve moving threads
into a collapsed resolved <details> section with reopen, and a
permission-aware composer — hidden with a hint when the pond's policy
bars the viewer (readers always see the discussion). The pond settings
page gains the "who may comment" select. Fixes PondsService.update
silently dropping commentPolicy from the settings merge (found by the
new two-user Playwright pack; the DB test now exercises the real pond
PATCH). New comments i18n namespace (de+en); the pack runs as its own
CI step.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwZ4jR4KFAPvpjWevfUGX1
2026-07-11 22:07:16 +02:00