Quota override cell stays a table cell, flex on an inner wrapper (#329)
All checks were successful
CI / Lint, typecheck, test (pull_request) Successful in 7m54s
CI / Build container images (pull_request) Successful in 1m25s
CI / Auth e2e pack (pull_request) Successful in 9m27s
CI / Import/export fidelity gate (pull_request) Successful in 55s
CD / Build and push images (push) Successful in 25s
CD / Deploy to Test (push) Successful in 12s
CD / Smoke tests against Test (push) Successful in 1m20s
CD / Promote to Int (push) Successful in 12s
CI / Lint, typecheck, test (push) Successful in 6m53s
CI / Build container images (push) Has been skipped
CI / Auth e2e pack (push) Successful in 9m0s
CI / Import/export fidelity gate (push) Successful in 59s
All checks were successful
CI / Lint, typecheck, test (pull_request) Successful in 7m54s
CI / Build container images (pull_request) Successful in 1m25s
CI / Auth e2e pack (pull_request) Successful in 9m27s
CI / Import/export fidelity gate (pull_request) Successful in 55s
CD / Build and push images (push) Successful in 25s
CD / Deploy to Test (push) Successful in 12s
CD / Smoke tests against Test (push) Successful in 1m20s
CD / Promote to Int (push) Successful in 12s
CI / Lint, typecheck, test (push) Successful in 6m53s
CI / Build container images (push) Has been skipped
CI / Auth e2e pack (push) Successful in 9m0s
CI / Import/export fidelity gate (push) Successful in 59s
Same defect and same fix as the user list's actions cell (#177): display:flex directly on the override td removed its table-cell behaviour, so the cell stopped growing to row height and its bottom border no longer met the row's — visibly uneven separator lines (Stefan's screenshot from the self-hosting walkthrough). The flex layout now lives on .quota-row__override-inner. Measured locally like #177: bottom-delta across all cells of every quota row was 24–49 px before, 0 px after (override set, so the cell carries input + two link buttons); admin-quotas e2e pack green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017aviRTgWCcAHUh1SBoxf6P
This commit is contained in:
parent
20677ea247
commit
64f2deb40f
@ -138,6 +138,10 @@ function QuotaRow({
|
||||
<td>{t(`keys.${line.key}`)}</td>
|
||||
<td>{line.instanceDefault}</td>
|
||||
<td className="quota-row__override">
|
||||
{/* Flex lives on the inner div: a td with display:flex stops behaving
|
||||
like a table cell and its bottom border no longer meets the row's
|
||||
(same fix as the user list's actions cell, #177). */}
|
||||
<div className="quota-row__override-inner">
|
||||
<input
|
||||
type="number"
|
||||
min={0}
|
||||
@ -153,6 +157,7 @@ function QuotaRow({
|
||||
{t('overrides.clear')}
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
</td>
|
||||
<td className="quota-row__effective">{line.effective}</td>
|
||||
<td className="quota-row__usage">
|
||||
|
||||
@ -3048,7 +3048,7 @@ ul[data-type='task_list'] li p:last-of-type {
|
||||
margin-bottom: var(--space-2);
|
||||
}
|
||||
|
||||
.quota-row__override {
|
||||
.quota-row__override-inner {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: var(--space-2);
|
||||
|
||||
Loading…
Reference in New Issue
Block a user